Minor validation logic improvements #782
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No more flaky tests? 😄 Hm, looks like this is still related? Is it just ACK (202)? |
pblazej
reviewed
Sep 11, 2025
pblazej
reviewed
Sep 11, 2025
Sources/LiveKit/Support/HTTP.swift
Outdated
| case valid | ||
| case invalid(message: String) | ||
| // Network error etc. | ||
| case unknown(error: Error) |
There was a problem hiding this comment.
IMO either throws/Result/Error where throws should be prioritized
|
Let's unblock this PR, 2 nitpicks:
Othwerwise, LGTM 🌮 |
pblazej
reviewed
Oct 20, 2025
| case webRTC = 201 | ||
|
|
||
| case network // Network issue | ||
| case validation // Network issue |
There was a problem hiding this comment.
Nit: I'd rename that to authorization (or better?), as this is very generic (not sure about other SDKs).
Otherwise LGTM^2
There was a problem hiding this comment.
I think we used to call this "validation", the endpoint (path is /validate)
So maybe validation is better ?
There was a problem hiding this comment.
If that matches backend, then why not
pblazej
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws different type of error if server validation failed